From 27e58363dde28f4667761970fc7068be8fe047ac Mon Sep 17 00:00:00 2001 From: Cara Salter Date: Mon, 3 Apr 2023 09:39:39 -0400 Subject: modules: Fix issue with unloading modules bound to OnMessage When unloaded, modules attached to OnMessage events would still be part of the list used by FOREACH_MOD to send events to, leading to a segfault. This changes the behavior of load and unload to place new modules at the *start* of the event handler arrays, leading them to already be processed by the time the bot gets to the ModuleManager. --- src/modules.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/modules.cpp') diff --git a/src/modules.cpp b/src/modules.cpp index b2e56e1..0c9fb18 100644 --- a/src/modules.cpp +++ b/src/modules.cpp @@ -57,7 +57,7 @@ ModuleLoader::ModuleLoader(Bot* creator): bot(creator) { void ModuleLoader::attach(const std::vector &i, Module* m) { for (auto n = i.begin(); n != i.end(); ++n) { if (std::find(EventHandlers[*n].begin(), EventHandlers[*n].end(), m) == EventHandlers[*n].end()) { - EventHandlers[*n].push_back(m); + EventHandlers[*n].insert(EventHandlers[*n].begin(), m); bot->core->log(dpp::ll_info, fmt::format("Module {} attached to event {}", m->description(), StringNames[*n])); } else { bot->core->log(dpp::ll_warning, fmt::format("Module {} already attached to event {}", m->description(), StringNames[*n])); -- cgit v1.2.3